fix: Avoid rejecting releases when extractVersion is used (#32376)

renovatebot · Nov 7, 2024 · b8835e4 · b8835e4
1 parent 8bbba57
commit b8835e4
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 0 deletions.
diff --git a/lib/modules/datasource/postprocess-release.spec.ts b/lib/modules/datasource/postprocess-release.spec.ts
@@ -124,6 +124,31 @@ describe('modules/datasource/postprocess-release', () => {
     expect(release).toBeNull();
   });
 
+  it('preserves rejected release when `extractVersion` was set', async () => {
+    const releaseOrig: Release = { version: '1.2.3' };
+
+    class SomeDatasource extends DummyDatasource {
+      override postprocessRelease(
+        _config: PostprocessReleaseConfig,
+        _release: Release,
+      ): Promise<PostprocessReleaseResult> {
+        return Promise.resolve('reject');
+      }
+    }
+    getDatasourceFor.mockReturnValueOnce(new SomeDatasource());
+
+    const release = await postprocessRelease(
+      {
+        datasource: 'some-datasource',
+        packageName: 'some-package',
+        extractVersion: '^(?<version>\\d+)$',
+      },
+      releaseOrig,
+    );
+
+    expect(release).toBe(releaseOrig);
+  });
+
   it('falls back when error was thrown', async () => {
     const releaseOrig: Release = { version: '1.2.3' };
 

diff --git a/lib/modules/datasource/postprocess-release.ts b/lib/modules/datasource/postprocess-release.ts
@@ -49,6 +49,20 @@ export async function postprocessRelease(
     );
 
     if (result === 'reject') {
+      if (config.extractVersion) {
+        logger.debug(
+          {
+            datasource,
+            packageName,
+            registryUrl,
+            version: release.version,
+            extractVersion: config.extractVersion,
+          },
+          'Rejected release combined with `extractVersion`: preserving the release',
+        );
+        return release;
+      }
+
       logger.debug(
         { datasource, packageName, registryUrl, version: release.version },
         'Rejected release',