Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to Jest v28 #15353

Closed
3 tasks done
HonkingGoose opened this issue Apr 28, 2022 · 7 comments · Fixed by #16109
Closed
3 tasks done

Update to Jest v28 #15353

HonkingGoose opened this issue Apr 28, 2022 · 7 comments · Fixed by #16109
Assignees
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Apr 28, 2022

Describe the proposed change(s).

We should update Jest from v27 to v28, as it has lots of nice features. 🥳

Benefits of v28

Requirements

  • TypeScript version 4.3 or above
  • Node versions 12.13, 14.15, 16.10 and above

Todo:

Jest blog post

For more information and all the breaking changes read the Jest 28 blog post.

@HonkingGoose HonkingGoose added type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Apr 28, 2022
@viceice
Copy link
Member

viceice commented Apr 30, 2022

@viceice viceice added status:blocked Issue is blocked by another issue or external requirement and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Apr 30, 2022
@viceice
Copy link
Member

viceice commented Apr 30, 2022

@HonkingGoose
Copy link
Collaborator Author

We'll need to upgrade ts-jest to v28.0.0, or higher, to get Jest 28 support.

I don't know why ts-jest doesn't show up on our Dependency Dashboard, maybe it's part of a group?

ts-jest changelog

@HonkingGoose HonkingGoose added status:ready and removed status:blocked Issue is blocked by another issue or external requirement labels May 9, 2022
@rarkins
Copy link
Collaborator

rarkins commented May 9, 2022

Checks are pending, so it's left out of the group.

DEBUG: Dependency ts-jest is part of group jest monorepo

          {
            "depType": "devDependencies",
            "depName": "ts-jest",
            "currentValue": "27.1.4",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "27.1.4",
            "depIndex": 159,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/kulshekhar/ts-jest",
            "homepage": "https://kulshekhar.github.io/ts-jest",
            "currentVersion": "27.1.4",
            "isSingleVersion": true,
            "fixedVersion": "27.1.4",
            "updates": [
              {
                "bucket": "major",
                "newVersion": "28.0.2",
                "newValue": "28.0.2",
                "releaseTimestamp": "2022-05-08T07:47:18.625Z",
                "newMajor": 28,
                "newMinor": 0,
                "updateType": "major",
                "pendingChecks": true,
                "branchName": "renovate/major-jest-monorepo"
              }
            ]
          },

@viceice
Copy link
Member

viceice commented May 9, 2022

We should wait for 28.0.2 because of a bad bug which maybe hit us

https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md#2802-2022-05-07

@HonkingGoose
Copy link
Collaborator Author

We should wait for 28.0.2 because of a bad bug which maybe hit us

https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md#2802-2022-05-07

ts-jest is at version 28.0.4 now, that should be good to go?

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 32.89.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants