Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(datasource/maven)!: skip pom check by default #30415

Closed
wants to merge 1 commit into from

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jul 27, 2024

Changes

Change from opt-out (RENOVATE_EXPERIMENTAL_NO_MAVEN_POM_CHECK) to opt-in (RENOVATE_EXPERIMENTAL_MAVEN_POM_CHECK) for POM validity checking.

Context

This causes many API requests and decreases performance, so should no longer be the default.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Change from opt-out (RENOVATE_EXPERIMENTAL_NO_MAVEN_POM_CHECK) to opt-in (RENOVATE_EXPERIMENTAL_MAVEN_POM_CHECK)
@rarkins rarkins requested review from viceice and secustor July 27, 2024 06:27
@rarkins rarkins changed the title feat(datasource/maven): skip pom check by default feat(datasource/maven)!: skip pom check by default Jul 27, 2024
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.

@viceice viceice added the breaking Breaking change, requires major version bump label Aug 2, 2024
@viceice viceice added this to the v39 milestone Aug 2, 2024
@rarkins
Copy link
Collaborator Author

rarkins commented Sep 22, 2024

Replaced by #31261

@rarkins rarkins closed this Sep 22, 2024
@rarkins rarkins deleted the feat/maven-pom-check branch September 30, 2024 15:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants