feat(maven): Use release post-fetch processing

docs/usage/self-hosted-experimental.md

@@ -19,11 +19,6 @@ We will try to keep breakage to a minimum, but make no guarantees that an experi
 If set, Renovate will export OpenTelemetry data to the supplied endpoint.
 For more information see [the OpenTelemetry docs](opentelemetry.md).
 
-## `RENOVATE_EXPERIMENTAL_NO_MAVEN_POM_CHECK`
-
-If set to any value, Renovate will skip its default artifacts filter check in the Maven datasource.
-Skipping the check will speed things up, but may result in versions being returned which don't properly exist on the server.
-
 ## `RENOVATE_PAGINATE_ALL`
 
 If set to any value, Renovate will always paginate requests to GitHub fully, instead of stopping after 10 pages.

lib/modules/datasource/clojure/__snapshots__/index.spec.ts.snap

@@ -13,15 +13,24 @@ exports[`modules/datasource/clojure/index falls back to next registry url 1`] =
       "version": "0.0.1",
     },
     {
-      "releaseTimestamp": "2020-01-01T01:00:00.000Z",
       "version": "1.0.0",
     },
     {
-      "releaseTimestamp": "2020-01-01T01:00:03.000Z",
+      "version": "1.0.1",
+    },
+    {
+      "version": "1.0.2",
+    },
+    {
       "version": "1.0.3-SNAPSHOT",
     },
     {
-      "releaseTimestamp": "2020-01-01T02:00:00.000Z",
+      "version": "1.0.4-SNAPSHOT",
+    },
+    {
+      "version": "1.0.5-SNAPSHOT",
+    },
+    {
       "version": "2.0.0",
     },
   ],
@@ -34,15 +43,24 @@ exports[`modules/datasource/clojure/index ignores unsupported protocols 1`] = `
     "version": "0.0.1",
   },
   {
-    "releaseTimestamp": "2020-01-01T01:00:00.000Z",
     "version": "1.0.0",
   },
   {
-    "releaseTimestamp": "2020-01-01T01:00:03.000Z",
+    "version": "1.0.1",
+  },
+  {
+    "version": "1.0.2",
+  },
+  {
     "version": "1.0.3-SNAPSHOT",
   },
   {
-    "releaseTimestamp": "2020-01-01T02:00:00.000Z",
+    "version": "1.0.4-SNAPSHOT",
+  },
+  {
+    "version": "1.0.5-SNAPSHOT",
+  },
+  {
     "version": "2.0.0",
   },
 ]
@@ -62,15 +80,24 @@ exports[`modules/datasource/clojure/index returns releases from custom repositor
       "version": "0.0.1",
     },
     {
-      "releaseTimestamp": "2020-01-01T01:00:00.000Z",
       "version": "1.0.0",
     },
     {
-      "releaseTimestamp": "2020-01-01T01:00:03.000Z",
+      "version": "1.0.1",
+    },
+    {
+      "version": "1.0.2",
+    },
+    {
       "version": "1.0.3-SNAPSHOT",
     },
     {
-      "releaseTimestamp": "2020-01-01T02:00:00.000Z",
+      "version": "1.0.4-SNAPSHOT",
+    },
+    {
+      "version": "1.0.5-SNAPSHOT",
+    },
+    {
       "version": "2.0.0",
     },
   ],
@@ -90,15 +117,24 @@ exports[`modules/datasource/clojure/index skips registry with invalid XML 1`] =
       "version": "0.0.1",
     },
     {
-      "releaseTimestamp": "2020-01-01T01:00:00.000Z",
       "version": "1.0.0",
     },
     {
-      "releaseTimestamp": "2020-01-01T01:00:03.000Z",
+      "version": "1.0.1",
+    },
+    {
+      "version": "1.0.2",
+    },
+    {
       "version": "1.0.3-SNAPSHOT",
     },
     {
-      "releaseTimestamp": "2020-01-01T02:00:00.000Z",
+      "version": "1.0.4-SNAPSHOT",
+    },
+    {
+      "version": "1.0.5-SNAPSHOT",
+    },
+    {
       "version": "2.0.0",
     },
   ],
@@ -118,15 +154,24 @@ exports[`modules/datasource/clojure/index skips registry with invalid metadata s
       "version": "0.0.1",
     },
     {
-      "releaseTimestamp": "2020-01-01T01:00:00.000Z",
       "version": "1.0.0",
     },
     {
-      "releaseTimestamp": "2020-01-01T01:00:03.000Z",
+      "version": "1.0.1",
+    },
+    {
+      "version": "1.0.2",
+    },
+    {
       "version": "1.0.3-SNAPSHOT",
     },
     {
-      "releaseTimestamp": "2020-01-01T02:00:00.000Z",
+      "version": "1.0.4-SNAPSHOT",
+    },
+    {
+      "version": "1.0.5-SNAPSHOT",
+    },
+    {
       "version": "2.0.0",
     },
   ],

lib/modules/datasource/clojure/index.spec.ts

@@ -12,7 +12,6 @@ const baseUrlCustom = 'https://custom.registry.renovatebot.com';
 
 interface SnapshotOpts {
   version: string;
-  jarStatus?: number;
   meta?: string;
 }
 
@@ -22,7 +21,6 @@ interface MockOpts {
   meta?: string | null;
   pom?: string | null;
   latest?: string;
-  jars?: Record<string, number> | null;
   snapshots?: SnapshotOpts[] | null;
 }
 
@@ -31,6 +29,7 @@ function mockGenericPackage(opts: MockOpts = {}) {
     dep = 'org.example:package',
     base = baseUrl,
     latest = '2.0.0',
+    snapshots,
   } = opts;
   const meta =
     opts.meta === undefined
@@ -40,39 +39,6 @@ function mockGenericPackage(opts: MockOpts = {}) {
     opts.pom === undefined
       ? Fixtures.get('pom.xml', upath.join('..', 'maven'))
       : opts.pom;
-  const jars =
-    opts.jars === undefined
-      ? {
-          '0.0.1': 200,
-          '1.0.0': 200,
-          '1.0.1': 404,
-          '1.0.2': 500,
-          '2.0.0': 200,
-        }
-      : opts.jars;
-  const snapshots =
-    opts.snapshots === undefined
-      ? [
-          {
-            version: '1.0.3-SNAPSHOT',
-            meta: Fixtures.get(
-              'metadata-snapshot-version.xml',
-              upath.join('..', 'maven'),
-            ),
-            jarStatus: 200,
-          },
-          {
-            version: '1.0.4-SNAPSHOT',
-            meta: Fixtures.get(
-              'metadata-snapshot-version-invalid.xml',
-              upath.join('..', 'maven'),
-            ),
-          },
-          {
-            version: '1.0.5-SNAPSHOT',
-          },
-        ]
-      : opts.snapshots;
 
   const scope = httpMock.scope(base);
 
@@ -89,22 +55,6 @@ function mockGenericPackage(opts: MockOpts = {}) {
       .reply(200, pom);
   }
 
-  if (jars) {
-    Object.entries(jars).forEach(([version, status]) => {
-      const [major, minor, patch] = version
-        .split('.')
-        .map((x) => parseInt(x, 10))
-        .map((x) => (x < 10 ? `0${x}` : `${x}`));
-      const timestamp = `2020-01-01T${major}:${minor}:${patch}.000Z`;
-      const headers: httpMock.ReplyHeaders = version.startsWith('0.')
-        ? {}
-        : { 'Last-Modified': timestamp };
-      scope
-        .head(`/${packagePath}/${version}/${artifact}-${version}.pom`)
-        .reply(status, '', headers);
-    });
-  }
-
   if (snapshots) {
     snapshots.forEach((snapshot) => {
       if (snapshot.meta) {
@@ -116,31 +66,6 @@ function mockGenericPackage(opts: MockOpts = {}) {
           .get(`/${packagePath}/${snapshot.version}/maven-metadata.xml`)
           .reply(404, '');
       }
-
-      if (snapshot.jarStatus) {
-        const [major, minor, patch] = snapshot.version
-          .replace('-SNAPSHOT', '')
-          .split('.')
-          .map((x) => parseInt(x, 10))
-          .map((x) => (x < 10 ? `0${x}` : `${x}`));
-        const timestamp = `2020-01-01T${major}:${minor}:${patch}.000Z`;
-        scope
-          .head(
-            `/${packagePath}/${
-              snapshot.version
-            }/${artifact}-${snapshot.version.replace(
-              '-SNAPSHOT',
-              '',
-            )}-20200101.${major}${minor}${patch}-${parseInt(patch, 10)}.pom`,
-          )
-          .reply(snapshot.jarStatus, '', { 'Last-Modified': timestamp });
-      } else {
-        scope
-          .head(
-            `/${packagePath}/${snapshot.version}/${artifact}-${snapshot.version}.pom`,
-          )
-          .reply(404, '');
-      }
     });
   }
 }
@@ -163,7 +88,6 @@ describe('modules/datasource/clojure/index', () => {
 
   afterEach(() => {
     hostRules.clear();
-    delete process.env.RENOVATE_EXPERIMENTAL_NO_MAVEN_POM_CHECK;
   });
 
   it('returns releases from custom repository', async () => {
@@ -180,7 +104,6 @@ describe('modules/datasource/clojure/index', () => {
       base: baseUrlCustom,
       meta: Fixtures.get('metadata-extra.xml', upath.join('..', 'maven')),
       latest: '3.0.0',
-      jars: { '3.0.0': 200 },
       snapshots: [],
     });
 
@@ -193,7 +116,11 @@ describe('modules/datasource/clojure/index', () => {
     expect(releases).toMatchObject([
       { version: '0.0.1' },
       { version: '1.0.0' },
+      { version: '1.0.1' },
+      { version: '1.0.2' },
       { version: '1.0.3-SNAPSHOT' },
+      { version: '1.0.4-SNAPSHOT' },
+      { version: '1.0.5-SNAPSHOT' },
       { version: '2.0.0' },
       { version: '3.0.0' },
     ]);