Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(manager/docker): accept key-only arguments in COPY --from #31344

Conversation

mkniewallner
Copy link
Contributor

@mkniewallner mkniewallner commented Sep 11, 2024

Changes

Accept key-only arguments when parsing COPY --from=<image> in docker files, e.g. COPY --link --from=<image>.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@mkniewallner mkniewallner force-pushed the fix/accept-key-only-arguments-copy-from-docker branch from 83bfd81 to 5a02b94 Compare September 11, 2024 21:37
@mkniewallner mkniewallner changed the title fix(manager/docker): accept key-only arguments fix(manager/docker): accept key-only arguments in COPY --from Sep 11, 2024
@mkniewallner mkniewallner marked this pull request as ready for review September 11, 2024 21:39
rarkins
rarkins previously approved these changes Sep 12, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/dockerfile/extract.spec.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice viceice added this pull request to the merge queue Sep 12, 2024
Merged via the queue into renovatebot:main with commit 83132a5 Sep 12, 2024
38 checks passed
@mkniewallner mkniewallner deleted the fix/accept-key-only-arguments-copy-from-docker branch September 12, 2024 18:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants