Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(config-migration): skip migration of package.json #33122

Merged

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Dec 15, 2024

Changes

  1. If config is present in package.json and migration is need:
    Prev: Add checkbox on dependency dashboard and if the user checks it create a migration PR (faulty PR)
    Now: No checkbox on dashboard instead a warning message is shown there asking the user to migrate to a dedicated config file

  2. If config is present in package.json and migration is needed and a faulty pr exists
    After this PR is merged, such open PRs will be closed and warning will be added on dashboard asking user to migrate to a dedicated config file

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository pt1-repro pt2-repro

@viceice viceice requested a review from rarkins December 15, 2024 17:14
@rarkins rarkins added this pull request to the merge queue Dec 16, 2024
Merged via the queue into renovatebot:main with commit 66dcb61 Dec 16, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.69.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Migrate Renovate Config" PR should not apply to package.json contents
4 participants