Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Hide timer cancel button #145

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Hide timer cancel button #145

merged 1 commit into from
Jul 3, 2024

Conversation

CuddlyBunion341
Copy link
Contributor

TICKET-19656

Apply hidden to hidden button.

QA

Why does this button exist?

  1. The cancel button belongs to a different action.
  2. Forms cannot be nested.
  3. Updating the form action based off the submit button value is challenging and error prone.
  4. It was easy to add it.
Before

CleanShot 2024-07-03 at 10 41 56@2x

After

CleanShot 2024-07-03 at 10 42 16@2x

@CuddlyBunion341 CuddlyBunion341 requested a review from coorasse July 3, 2024 08:44
@CuddlyBunion341 CuddlyBunion341 self-assigned this Jul 3, 2024
@coorasse coorasse merged commit cd9676b into main Jul 3, 2024
2 checks passed
@coorasse coorasse deleted the feature/19656-hide-timer-cancel-button branch July 3, 2024 14:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@coorasse coorasse coorasse approved these changes

Assignees

@CuddlyBunion341 CuddlyBunion341

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CuddlyBunion341 @coorasse