WIP configurable upper bound on locking attempt timeout

reorg · Jun 1, 2021 · e791f2a · e791f2a
1 parent ebc8a42
commit e791f2a
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/bin/pg_repack.c b/bin/pg_repack.c
@@ -249,6 +249,7 @@ static bool				moveidx = false;
 static SimpleStringList	r_index = {NULL, NULL};
 static bool				only_indexes = false;
 static int				wait_timeout = 60;	/* in seconds */
+static int				max_lock_timeout_msec = 1000;
 static int				jobs = 0;	/* number of concurrent worker conns. */
 static bool				dryrun = false;
 static unsigned int		temp_obj_num = 0; /* temporary objects counter */
@@ -279,6 +280,7 @@ static pgut_option options[] =
 	{ 'l', 'i', "index", &r_index },
 	{ 'b', 'x', "only-indexes", &only_indexes },
 	{ 'i', 'T', "wait-timeout", &wait_timeout },
+	{ 'i', 'm', "max-lock-timeout", &max_lock_timeout_msec },
 	{ 'B', 'Z', "no-analyze", &analyze },
 	{ 'i', 'j', "jobs", &jobs },
 	{ 'b', 'D', "no-kill-backend", &no_kill_backend },
@@ -1767,6 +1769,7 @@ lock_exclusive(PGconn *conn, const char *relid, const char *lock_query, bool sta
 		char		sql[1024];
 		PGresult   *res;
 		int			wait_msec;
+		int			timeout_msec;
 
 		if (start_xact)
 			pgut_command(conn, "BEGIN ISOLATION LEVEL READ COMMITTED", 0, NULL);
@@ -1815,7 +1818,8 @@ lock_exclusive(PGconn *conn, const char *relid, const char *lock_query, bool sta
 
 		/* wait for a while to lock the table. */
 		wait_msec = Min(1000, i * 100);
-		snprintf(sql, lengthof(sql), "SET LOCAL statement_timeout = %d", wait_msec);
+		timeout_msec = Min(wait_msec, max_lock_timeout_msec)
+		snprintf(sql, lengthof(sql), "SET LOCAL statement_timeout = %d", timeout_msec);
 		pgut_command(conn, sql, 0, NULL);
 
 		res = pgut_execute_elevel(conn, lock_query, 0, NULL, DEBUG2);
@@ -1832,6 +1836,8 @@ lock_exclusive(PGconn *conn, const char *relid, const char *lock_query, bool sta
 				pgut_rollback(conn);
 			else
 				pgut_command(conn, "ROLLBACK TO SAVEPOINT repack_sp1", 0, NULL);
+			if (timeout_msec < wait_msec)
+				usleep(1000 * (wait_msec - timeout_msec));
 			continue;
 		}
 		else
@@ -2232,6 +2238,7 @@ pgut_help(bool details)
 	printf("  -i, --index=INDEX         move only the specified index\n");
 	printf("  -x, --only-indexes        move only indexes of the specified table\n");
 	printf("  -T, --wait-timeout=SECS   timeout to cancel other backends on conflict\n");
+	printf("  -m, --max-lock-timeout=MS max millisecond timeout for a strong lock attempt\n");
 	printf("  -D, --no-kill-backend     don't kill other backends when timed out\n");
 	printf("  -Z, --no-analyze          don't analyze at end\n");
 	printf("  -k, --no-superuser-check  skip superuser checks in client\n");