Fix failing tablespace tests

.github/workflows/regression.yml

@@ -33,7 +33,7 @@ jobs:
         run: echo "$PWD/bin" >> $GITHUB_PATH
 
       - name: Create testts directory
-        run: sudo -u postgres mkdir /tmp/testts
+        run: sudo -u postgres mkdir -p /tmp/testts && chmod 0700 /tmp/testts
 
       - name: Create testts tablespace
         run: sudo -u postgres psql -c "CREATE TABLESPACE testts LOCATION '/tmp/testts'"
@@ -44,3 +44,10 @@ jobs:
       - name: Show regression.diffs
         if: ${{ failure() }}
         run: cat regress/regression.diffs
+
+      - name: Remove tests tablespace
+        run: sudo -u postgres psql -c "DROP TABLESPACE testts"
+
+      - name: Remove testts directory
+        run: sudo -u postgres rm -rf /tmp/testts
+

regress/expected/tablespace.out

@@ -4,6 +4,10 @@ SET client_min_messages = warning;
 --
 -- Note: in order to pass this test you must create a tablespace called 'testts'
 --
+-- Test tablespace creation example:
+--   $ sudo -u postgres mkdir -p /tmp/testts && chmod 0700 /tmp/testts
+--   $ sudo -u postgres psql -c "CREATE TABLESPACE testts LOCATION '/tmp/testts'"
+--
 SELECT spcname FROM pg_tablespace WHERE spcname = 'testts';
  spcname 
 ---------
@@ -245,3 +249,5 @@ ORDER BY relname;
 --using --indexes-only and --index option together
 \! pg_repack --dbname=contrib_regression --table=testts1 --only-indexes --index=testts1_pkey
 ERROR: cannot specify --index (-i) and --table (-t)
+-- cleanup
+DROP TABLE testts1;

regress/expected/tablespace_1.out

@@ -4,6 +4,10 @@ SET client_min_messages = warning;
 --
 -- Note: in order to pass this test you must create a tablespace called 'testts'
 --
+-- Test tablespace creation example:
+--   $ sudo -u postgres mkdir -p /tmp/testts && chmod 0700 /tmp/testts
+--   $ sudo -u postgres psql -c "CREATE TABLESPACE testts LOCATION '/tmp/testts'"
+--
 SELECT spcname FROM pg_tablespace WHERE spcname = 'testts';
  spcname 
 ---------
@@ -245,3 +249,5 @@ ORDER BY relname;
 --using --indexes-only and --index option together
 \! pg_repack --dbname=contrib_regression --table=testts1 --only-indexes --index=testts1_pkey
 ERROR: cannot specify --index (-i) and --table (-t)
+-- cleanup
+DROP TABLE testts1;

regress/expected/tablespace_2.out

@@ -4,6 +4,10 @@ SET client_min_messages = warning;
 --
 -- Note: in order to pass this test you must create a tablespace called 'testts'
 --
+-- Test tablespace creation example:
+--   $ sudo -u postgres mkdir -p /tmp/testts && chmod 0700 /tmp/testts
+--   $ sudo -u postgres psql -c "CREATE TABLESPACE testts LOCATION '/tmp/testts'"
+--
 SELECT spcname FROM pg_tablespace WHERE spcname = 'testts';
  spcname 
 ---------
@@ -245,3 +249,5 @@ ORDER BY relname;
 --using --indexes-only and --index option together
 \! pg_repack --dbname=contrib_regression --table=testts1 --only-indexes --index=testts1_pkey
 ERROR: cannot specify --index (-i) and --table (-t)
+-- cleanup
+DROP TABLE testts1;

regress/expected/tablespace_3.out

@@ -4,6 +4,10 @@ SET client_min_messages = warning;
 --
 -- Note: in order to pass this test you must create a tablespace called 'testts'
 --
+-- Test tablespace creation example:
+--   $ sudo -u postgres mkdir -p /tmp/testts && chmod 0700 /tmp/testts
+--   $ sudo -u postgres psql -c "CREATE TABLESPACE testts LOCATION '/tmp/testts'"
+--
 SELECT spcname FROM pg_tablespace WHERE spcname = 'testts';
  spcname 
 ---------
@@ -245,3 +249,5 @@ ORDER BY relname;
 --using --indexes-only and --index option together
 \! pg_repack --dbname=contrib_regression --table=testts1 --only-indexes --index=testts1_pkey
 ERROR: cannot specify --index (-i) and --table (-t)
+-- cleanup
+DROP TABLE testts1;

regress/expected/tablespace_4.out

@@ -4,6 +4,10 @@ SET client_min_messages = warning;
 --
 -- Note: in order to pass this test you must create a tablespace called 'testts'
 --
+-- Test tablespace creation example:
+--   $ sudo -u postgres mkdir -p /tmp/testts && chmod 0700 /tmp/testts
+--   $ sudo -u postgres psql -c "CREATE TABLESPACE testts LOCATION '/tmp/testts'"
+--
 SELECT spcname FROM pg_tablespace WHERE spcname = 'testts';
  spcname 
 ---------
@@ -245,3 +249,5 @@ ORDER BY relname;
 --using --indexes-only and --index option together
 \! pg_repack --dbname=contrib_regression --table=testts1 --only-indexes --index=testts1_pkey
 ERROR: cannot specify --index (-i) and --table (-t)
+-- cleanup
+DROP TABLE testts1;

regress/sql/tablespace.sql

@@ -5,6 +5,10 @@ SET client_min_messages = warning;
 --
 -- Note: in order to pass this test you must create a tablespace called 'testts'
 --
+-- Test tablespace creation example:
+--   $ sudo -u postgres mkdir -p /tmp/testts && chmod 0700 /tmp/testts
+--   $ sudo -u postgres psql -c "CREATE TABLESPACE testts LOCATION '/tmp/testts'"
+--
 
 SELECT spcname FROM pg_tablespace WHERE spcname = 'testts';
 -- If the query above failed you must create the 'testts' tablespace;
@@ -147,3 +151,7 @@ ORDER BY relname;
 
 --using --indexes-only and --index option together
 \! pg_repack --dbname=contrib_regression --table=testts1 --only-indexes --index=testts1_pkey
+
+-- cleanup
+DROP TABLE testts1;
+