Provider logic + Controllers

[ignaciosantise]

Summary

• Added provider initialization
• Added controllers based on web3modal implementation
• Added basic view to show user address + disconnect button

Screenshots

iOS

RPReplay_Final1680550038.MP4

Android

android.mp4

[xzilja]

Really cool stuff!

• I left few comments on code style, that apply all around. I think it might be time to introduce tools like eslint / prettier to catch them? Also perhaps set up github actions to run these checks on pr's (refference in web repo).

• I noticed that old explorer api is in use, we now have web3modal specific endpoints, feel free to ping me about these to discuss.

• We can probably remove x1 images (maybe even x2), as likelihood of someone using these even on older phones is very very low and we might benefit from less maintenance, but will leave this up to you.

• I usually don't leave any comments / todo's in, but since we are early in dev, it's probably ok, just make sure to not forget about them.

[ignaciosantise]

Thanks for your feedback @0xasimetriq 🎉

About image sizes, im following react-native docs recommendations, and i think there's no maintenance problem because Figma has the option to export in all sizes.

[crypblizz8]

I left few comments on code style, that apply all around. I think it might be time to introduce tools like eslint / prettier to catch them? Also perhaps set up github actions to run these checks on pr's (refference in web repo).

+1 @0xasimetriq so let's add some GHub Actions for this. Maybe also let's consider leaving an Expo Snack as our version of Vercel. Then we can easily scan without having to do the xCode / RN CLI setup each time? Do you know of any other streamlined flows @ignaciosantise ?

[ignaciosantise]

@crypblizz8 the repo has some actions, but they execute when the base of the PR is main.

I'll try to add the QR Code for expo 🎉 good idea

[crypblizz8]

NonBlocking: Let's also add a README to the main directory and for examples.

[crypblizz8]

I sometimes found that it was necessary during RN Development to keep the React part but not sure if it errors. If no errors, looks good.

[ignaciosantise]

since React 17, there's no need to import React. I disabled the rule that marked the missing import as an error.

[crypblizz8]

NonBlocking: when I did a yarn on the examples repo, it asked me to
✔ It looks like you're trying to use TypeScript but don't have the required dependencies installed. Would you like to install typescript@^4.9.4, @types/react@~18.0.27? … yes

Is this something we need to add or is it more an expo thing?

[crypblizz8]

Running into this while doing examples. I did yarn and normal Expo scan/ login. Added projectID. Anything I am missing?

[crypblizz8]

I see this export + from initial search in VSCode it shows it is exported in index.tsx. Is there specific usage of this used in examples or elsewhere? Apologies if I am missing something

[ignaciosantise]

the exports in index.tsx are the "public" exports from the SDK, that are used in the example app.

in the app we can import this:
import { Web3Modal, Web3Button, useWeb3Modal } from '@web3modal/react-native';

[ignaciosantise]

NonBlocking: when I did a yarn on the examples repo, it asked me to ✔ It looks like you're trying to use TypeScript but don't have the required dependencies installed. Would you like to install typescript@^4.9.4, @types/react@~18.0.27? … yes

Is this something we need to add or is it more an expo thing?

To run this example go to the root folder and:

1. Run yarn to install all deps
2. Run yarn example android or yarn example ios

[xzilja]

Looks good, left few comments 👍

[xzilja]

Should these be unsubscribed from somewhere i.e. instead of useCallback, perhaps put them in useEffect and remove when unmounting?

[ignaciosantise]

you are right, i didn't know there was a function to remove those listeners. Should we add something in the docs?