Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add error message for invalid project id #3579

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Jan 6, 2025

Description

Added error message for debug mode when a user provides an invalid project id

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1372

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: c651f1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-utils Patch
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 6:40pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 6:40pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-vue-solana ⬜️ Ignored (Inspect) Jan 6, 2025 6:40pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jan 6, 2025 6:40pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jan 6, 2025 6:40pm

Copy link

linear bot commented Jan 6, 2025

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 63.81% 18004 / 28211
🔵 Statements 63.81% 18004 / 28211
🔵 Functions 54.09% 1540 / 2847
🔵 Branches 78% 2894 / 3710
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit-utils/src/ErrorUtil.ts 85.41% 100% 0% 85.41% 25-27, 32, 50-52
Generated in workflow #8598 for commit c651f1a by the Vitest Coverage Report Action

@magiziz magiziz merged commit 8ddfbf2 into main Jan 7, 2025
19 checks passed
@magiziz magiziz deleted the chore/add-error-message-for-bad-project-id branch January 7, 2025 09:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants