Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upload aarch64 cog binary release #1841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upload aarch64 cog binary release #1841

wants to merge 1 commit into from

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Jul 31, 2024

  • aarch64 is actually exactly the same as arm64
  • Unfortunately because of uname sometimes the architecture is reported as aarch64
  • This how most people download our binaries, so if we don’t provide this path we end up not
    supporting this platform as well as we should.
  • Fixes: Support aarch64 builds #1828

As an aside, I'm a bit unsure how to test this because it lives in the release deployment.

* aarch64 is actually exactly the same as arm64
* Unfortunately because of uname sometimes the
architecture is reported as aarch64
* This how most people download our binaries, so
if we don’t provide this path we end up not
supporting this platform as well as we should.
@8W9aG 8W9aG requested a review from mattt July 31, 2024 14:39
@mattt
Copy link
Contributor

mattt commented Jul 31, 2024

@8W9aG Nice! We're several versions behind on goreleaser, using v4 instead of v6 (#1766) and using v0 configuration instead of v2. Is this something we could fix instead by upgrading to newer version of goreleaser software or configuration?

@8W9aG
Copy link
Contributor Author

8W9aG commented Jul 31, 2024

@8W9aG Nice! We're several versions behind on goreleaser, using v4 instead of v6 (#1766) and using v0 configuration instead of v2. Is this something we could fix instead by upgrading to newer version of goreleaser software or configuration?

Certainly I can give that a go, would you happen to have any ideas on how to test it though? Perhaps its just a more involved release next time where we watch it in realtime to make sure it executes as expected.

@mattt
Copy link
Contributor

mattt commented Aug 1, 2024

@8W9aG goreleaser should be runnable locally, so you could tweak the settings until it gives you what you need. Once you have a configuration that works for you, we can test out the integration with a new 0.9.x patch release (we need to do this anyway to get a new Python library package published)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support aarch64 builds
2 participants