Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a cog integration test for apt-packages #2104

Merged
merged 11 commits into from
Jan 13, 2025
Merged

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Jan 8, 2025

  • Ensure that apt-packages are installed in the main docker image file
  • Previously they were installed in a separate stage and not copied over

Copy link
Contributor

@aron aron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just wanted to clarify the setup.

8W9aG added 3 commits January 9, 2025 09:47
* Ensure that apt-packages are installed in the
main docker image file
* Previously they were installed in a separate
stage and not copied over
@8W9aG 8W9aG force-pushed the add-cog-int-test-apt-packages branch from 7b79594 to 9e3af97 Compare January 9, 2025 14:47
8W9aG added 2 commits January 9, 2025 10:10
* Make clean was not removing dependencies
installed by tox
@8W9aG 8W9aG requested a review from aron January 9, 2025 15:22
8W9aG and others added 6 commits January 13, 2025 06:53
Co-authored-by: F <f@replicate.com>
Signed-off-by: Will Sackfield <will.sackfield@gmail.com>
Co-authored-by: F <f@replicate.com>
Signed-off-by: Will Sackfield <will.sackfield@gmail.com>
Co-authored-by: F <f@replicate.com>
Signed-off-by: Will Sackfield <will.sackfield@gmail.com>
Co-authored-by: F <f@replicate.com>
Signed-off-by: Will Sackfield <will.sackfield@gmail.com>
Co-authored-by: F <f@replicate.com>
Signed-off-by: Will Sackfield <will.sackfield@gmail.com>
@8W9aG 8W9aG requested a review from erbridge January 13, 2025 15:41
@8W9aG 8W9aG merged commit 6eb2d2e into main Jan 13, 2025
21 checks passed
@8W9aG 8W9aG deleted the add-cog-int-test-apt-packages branch January 13, 2025 15:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants