Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes abstract methods from base collection, leaving each collection to define its own
get
/create
/list
methods on its own terms.The primary benefit to having abstract methods defined was to reuse shared logic for
reload
, but that method is short and required additional maneuvering to define anid
field. The downside of this tight coupling was that resources were required to implement methods that would raiseNotImplemented
. And their signatures forcreate
methods were inflexible, requiring either a mismatch with the parent class or an elaborate workaround with overloads and unpacked typed dict kwargs.