Repo ranger merged immediately without waiting for passing events

[moltar]

I created a PR using a CLI:

 hub pull-request -p -l "merge when passing"

The bot merged my PR immediately, 2 seconds after the PR was created.

I think this might be a race condition, as GitHub Actions did not start yet, and bot thought that everything was done.

Maybe the bot needs to detect checks that haven't started yet, or allow for some grace period before merging?

[mfix22]

@moltar sorry to hear this happened to you, and thank you for reporting it. I had not seen this issue in the past.

It does seem to me to be a race condition with GitHub actions, so I am going to add a delay to our response, and push up the fix tonight.

Give it another try whenever you have a chance, and let me know if it works. Might need to tweak our delay some more.

[mfix22]

Great use of hub, by the way!

[moltar]

Thank you 🙏

Will try again soon!

[mfix22]

Thanks @moltar! 🙏

[moltar]

Seems to work fine now! :)

Evidence: https://github.com/ScaleLeap/logger/pull/75

[mfix22]

@moltar thank you so much for checking! ❤️