Revert "fix issue #60"

This reverts commit 397cdc1.
reporanger · Aug 31, 2020 · 04a540e · 04a540e
1 parent 650fa7a
commit 04a540e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/pull/labeled.js b/src/pull/labeled.js
@@ -142,12 +142,12 @@ module.exports.process = (robot) => async ({
         (s) =>
           s.conclusion !== CONCLUSION.SUCCESS &&
           s.conclusion !== CONCLUSION.NEUTRAL &&
-          s.conclusion !== CONCLUSION.SKIPPED
-        // Currently check suites like https://github.com/NLog/NLog/pull/3296/checks were being
-        // queued and never concluding. You can see that in this API response:
-        // https://api.github.com/repos/NLog/Nlog/commits/2c8f7471648f22fa5dc9bf6db53e96fae061fc0a/check-suites
-        // Corresponding issue: https://github.com/mfix22/ranger/issues/60
-        // s.conclusion !== null
+          s.conclusion !== CONCLUSION.SKIPPED &&
+          // TODO remove this. Currently check suites like https://github.com/NLog/NLog/pull/3296/checks are being
+          // queued and never concluding. You can see that in this API response:
+          // https://api.github.com/repos/NLog/Nlog/commits/2c8f7471648f22fa5dc9bf6db53e96fae061fc0a/check-suites
+          // Corresponding issue: https://github.com/mfix22/ranger/issues/60
+          s.conclusion !== null
       )
     ) {
       throw new Retry()

diff --git a/test/index.test.js b/test/index.test.js
@@ -605,7 +605,7 @@ describe('pull_request', () => {
   })
 
   test.each([
-    // [null, true], was used for https://github.com/dawnlabs/ranger/issues/60
+    [null, true], // TODO https://github.com/dawnlabs/ranger/issues/60
     [CONCLUSION.SUCCESS, true],
     [CONCLUSION.NEUTRAL, true],
     [CONCLUSION.TIMED_OUT, false],