add installationId, use name, use mockResolvedValue

reporanger · Jan 9, 2019 · cc79510 · cc79510
1 parent 004fea4
commit cc79510
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 15 deletions.
diff --git a/src/analytics.js b/src/analytics.js
@@ -2,6 +2,7 @@ exports.installed = (robot, airtable) => async ({
   payload: { installation, repositories, repositories_added }
 }) => {
   const {
+    id: installationId,
     account: { login, type }
   } = installation
 
@@ -10,7 +11,13 @@ exports.installed = (robot, airtable) => async ({
   try {
     await Promise.all(
       repos.map(repo =>
-        airtable('installed').create({ login, type, repo: repo.full_name, private: repo.private })
+        airtable('installed').create({
+          login,
+          type,
+          repo: repo.name,
+          private: repo.private,
+          installationId
+        })
       )
     )
   } catch (e) {

diff --git a/test/fixtures/added.js b/test/fixtures/added.js
@@ -3,7 +3,7 @@ module.exports = ({ action = 'added', repositories_added }) => ({
   payload: {
     action,
     installation: {
-      id: 533899,
+      id: 42,
       account: {
         login: 'ranger',
         id: 1,

diff --git a/test/fixtures/installed.js b/test/fixtures/installed.js
@@ -3,7 +3,7 @@ module.exports = ({ action = 'created', repositories }) => ({
   payload: {
     action,
     installation: {
-      id: 533899,
+      id: 42,
       account: {
         login: 'ranger',
         id: 1,

diff --git a/test/index.test.js b/test/index.test.js
@@ -91,14 +91,8 @@ jest.mock(
   () =>
     class MockAirtable {
       constructor() {
-        this.create = jest.fn(() => {
-          return Promise.resolve()
-        })
-        this.base = () => () => {
-          return {
-            create: this.create
-          }
-        }
+        this.create = jest.fn().mockResolvedValue()
+        this.base = () => () => ({ create: this.create })
       }
     }
 )
@@ -603,8 +597,8 @@ describe('Bot', () => {
       repos => installedPayload({ repositories: repos })
     ])('Will track installations', async createPayload => {
       const repos = [
-        { full_name: 'ranger/test-0', private: true },
-        { full_name: 'ranger/test-1', private: false }
+        { name: 'ranger/test-0', private: true },
+        { name: 'ranger/test-1', private: false }
       ]
 
       await robot.receive(createPayload(repos))
@@ -613,8 +607,9 @@ describe('Bot', () => {
         expect(airtable('installed').create).toHaveBeenCalledWith({
           login: 'ranger',
           type: 'User',
-          repo: repo.full_name,
-          private: repo.private
+          repo: repo.name,
+          private: repo.private,
+          installationId: 42
         })
       })
     })