use Promise.allSettled

reporanger · Aug 24, 2020 · dde1773 · dde1773
1 parent 9a507f0
commit dde1773
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -40,7 +40,7 @@
     "prettier": "^2.0.5"
   },
   "engines": {
-    "node": ">= 8.3.0"
+    "node": "12.x"
   },
   "jest": {
     "collectCoverageFrom": [

diff --git a/scripts/write-installations-to-segment.js b/scripts/write-installations-to-segment.js
@@ -37,7 +37,7 @@ fetch('https://api.github.com/app/installations?per_page=100', {
 })
   .then((res) => res.json())
   .then(async (installations) => {
-    return Promise.all(
+    return Promise.allSettled(
       installations.map(async (i) => {
         const user = await fetchData(i.account.login)
         const email = user.email

diff --git a/src/comment/created.js b/src/comment/created.js
@@ -14,7 +14,7 @@ module.exports = () => async (context) => {
 
   if (!Array.isArray(config.comments)) return
 
-  await Promise.all(
+  await Promise.allSettled(
     config.comments.map(async ({ action, pattern, labels } = {}) => {
       if (pattern === '$PROFANITY') {
         if (!filter.isProfane(body)) {

diff --git a/src/installation/added.js b/src/installation/added.js
@@ -43,7 +43,7 @@ module.exports = (robot) => async (context) => {
           user: context.payload.installation.account.login,
         },
       }))
-      return Promise.all(
+      return Promise.allSettled(
         LABELS_TO_CREATE.map((l) => {
           const data = {
             owner: context.payload.installation.account.login,
@@ -72,7 +72,7 @@ module.exports = (robot) => async (context) => {
       )
     })
 
-    await Promise.all(promises)
+    await Promise.allSettled(promises)
 
     const private_repos = repos.filter((r) => r.private)
     analytics.track({

diff --git a/src/pull/merged.js b/src/pull/merged.js
@@ -21,7 +21,7 @@ module.exports.deleteBranch = () => async (context) => {
 
   if (!Array.isArray(config.merges)) return
 
-  await Promise.all(
+  await Promise.allSettled(
     config.merges.map(async (c) => {
       const action = c.action || c
 

diff --git a/src/pull/synchronized.js b/src/pull/synchronized.js
@@ -22,7 +22,7 @@ module.exports = () => async (context) => {
 
   if (!Array.isArray(config.commits)) return
 
-  await Promise.all(
+  await Promise.allSettled(
     config.commits.map(async ({ action, pattern, user, labels } = {}) => {
       return executeAction(action, {
         [LABEL]: () => {

diff --git a/src/thread/labeled.js b/src/thread/labeled.js
@@ -18,7 +18,7 @@ module.exports = (queue) => async (context) => {
 
   const ID = getId(context, { action: COMMENT })
 
-  await Promise.all(
+  await Promise.allSettled(
     thread.labels.map((label) => {
       const action = labelToAction(config, label)