-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Improves the display of brief views for documents. * Adds a `publicationPipe` for displaying text for document's publications. * Adds a configuration object to facilitate testing. * Closes rero/sonar#253. Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
- Loading branch information
Sébastien Délèze
committed
Jul 21, 2020
1 parent
cc78311
commit 5f74dee
Showing
10 changed files
with
324 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
projects/sonar/src/app/record/document/publication.pipe.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| /* | ||
| * SONAR User Interface | ||
| * Copyright (C) 2020 RERO | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as published by | ||
| * the Free Software Foundation, version 3 of the License. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| import { TestBed } from '@angular/core/testing'; | ||
| import { TranslateService } from '@rero/ng-core'; | ||
| import { mockedConfiguration } from '../../../../tests/utils'; | ||
| import { PublicationPipe } from './publication.pipe'; | ||
|
|
||
| let pipe: PublicationPipe; | ||
|
|
||
| describe('PublicationPipe', () => { | ||
| beforeEach(() => { | ||
| TestBed.configureTestingModule(mockedConfiguration); | ||
|
|
||
| pipe = new PublicationPipe(TestBed.get(TranslateService)); | ||
| }); | ||
|
|
||
| it('create an instance', () => { | ||
| expect(pipe).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should return empty publication', () => { | ||
| expect(pipe.transform({})).toBe(''); | ||
| }); | ||
|
|
||
| it('should return only document', () => { | ||
| expect(pipe.transform({ document: { title: 'Journal' } })).toBe('Journal'); | ||
| }); | ||
|
|
||
| it('should return document and year', () => { | ||
| expect( | ||
| pipe.transform({ document: { title: 'Journal' }, numberingYear: '2000' }) | ||
| ).toBe('Journal, 2000'); | ||
| }); | ||
|
|
||
| it('should return document, year and issue', () => { | ||
| expect( | ||
| pipe.transform({ | ||
| document: { title: 'Journal' }, | ||
| numberingYear: '2000', | ||
| numberingIssue: '12', | ||
| }) | ||
| ).toBe('Journal, 2000, no. 12'); | ||
| }); | ||
|
|
||
| it('should return document, year, issue and volume', () => { | ||
| expect( | ||
| pipe.transform({ | ||
| document: { title: 'Journal' }, | ||
| numberingYear: '2000', | ||
| numberingIssue: '12', | ||
| numberingVolume: '1', | ||
| }) | ||
| ).toBe('Journal, 2000, vol. 1, no. 12'); | ||
| }); | ||
|
|
||
| it('should return document, year, issue, volume and pages', () => { | ||
| expect( | ||
| pipe.transform({ | ||
| document: { title: 'Journal' }, | ||
| numberingYear: '2000', | ||
| numberingIssue: '12', | ||
| numberingVolume: '1', | ||
| numberingPages: '20-25', | ||
| }) | ||
| ).toBe('Journal, 2000, vol. 1, no. 12, p. 20-25'); | ||
| }); | ||
| }); |
Oops, something went wrong.