Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Some controlled affiliations are not correct. #362

Closed
pronguen opened this issue Oct 21, 2020 · 0 comments · Fixed by #372
Closed

Some controlled affiliations are not correct. #362

pronguen opened this issue Oct 21, 2020 · 0 comments · Fixed by #372
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor
Milestone
v1.0.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Oct 21, 2020 •
edited
Loading

The check of the controlled affiliation must be more strict.

  • Example 1. In the screenshot below, it identifies IST (Institut universitaire romand de santé au travail), since the string ist is found in Rämistrasse.
    The check should look for the string IST with, before and after, a space, a punctuation or the beginning/end of the string.

image

HEG solves it by searching for blank_IST_blank.

  • Example 2. In the screenshot below, it identifies "zurich university", which represents both "Uni of Zurich and Hospital" and "ZHdK (Zurich)". Solution: remove "zurich university" from the affiliation file.

image

HEG solves it by acting beyond string matching with additional rules for resolving affiliations: "Actually, we already resolve one similar case with a post-matching rule: "swiss federal institute of technology" is matched then post-ruled-resolved into "lausanne" or "zurich". This is: matching for large recall, then rules for precision."
@sebdeleze sebdeleze added 3 bug Breaks something but is not blocking labels Nov 30, 2020
@sebdeleze sebdeleze added this to the v1.0.0 milestone Nov 30, 2020
@sebdeleze sebdeleze mentioned this issue Dec 2, 2020
Merged
sebdeleze pushed a commit that referenced this issue Dec 16, 2020
projects: add resource
fd1e8f6 
Creates a project resource, with CRUD operations and permissions to access this resource and links projects to documents.

* Creates the files for handling `project` resource.
* Configures REST endpoint for `project` resource.
* Adds permissions for projects when logged user is serialized.
* Compiles JSON schema for `project` resource in bootstrap's script.
* Adds a common schema for `identifiedby` field.
* Fixes values for type and fields ordering for contributor identifier in documents.
* Adds a `projects` property to document's JSON schema.
* Adds a `projects` property to document's elasticsearch mapping.
* Serializes `projects` property in marshmallow schema.
* Adds `autocomplete_name` property to project's elasticsearch mapping, to be able to search projects in typehead.
* Adds a method in documents API, to get documents linked to a given project.
* Serializes `documents` in project marshmallow schema and formats data before dumping JSON.
* Calls `replace_refs` method to get projects information in document detail view.
* Displays projects associated to document in document's detail view.
* Adds a view to display project details.
* Adds a filter for formatting a date in jinja templates.
* Fixes an error with `identifiedBy` field, when the model is not available.
* Adds projects to documents when it is created from a deposit.
* Adds `projects` property to deposit JSON schema.
* Adds `projects` property to deposit marshmallow schema.
* Creates a class for handling controlled affiliations.
* Guesses controlled affiliation when a document or a project is created or updated.
* Closes #358.
* Closes #362.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze added the f: editor Concerns editor based on JSON schema AND custom editor label Jan 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

projects: add resource
2 participants
@sebdeleze @pronguen