Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow the definition of custom metadata fields and facets [5] #512

Closed
sebdeleze opened this issue Mar 17, 2021 · 4 comments · Fixed by #525
Closed

Allow the definition of custom metadata fields and facets [5] #512

sebdeleze opened this issue Mar 17, 2021 · 4 comments · Fixed by #525

Comments

@sebdeleze
Copy link
Contributor

In Dedicated portals, organisations have the possibility to request the addition of up to 3 custom fields within the publication's metadata, in order to fill internal needs beyond SONAR's standard metadata schema.

These fields can be exploited by corresponding custom facets, if requested.
@sebdeleze sebdeleze changed the title Allow the definition of custom metadata fields and facets Allow the definition of custom metadata fields and facets [8] Mar 17, 2021
@sebdeleze sebdeleze changed the title Allow the definition of custom metadata fields and facets [8] Allow the definition of custom metadata fields and facets [5] Mar 17, 2021
@sebdeleze sebdeleze mentioned this issue Apr 13, 2021
Merged
@mmo mmo mentioned this issue Apr 23, 2021
Closed
@mmo
Copy link
Collaborator

mmo commented Apr 23, 2021

Tested and approved, but some features are missing:

  • The custom metadata fields do not appear in the deposit process, only in the full document editor. [Note: after discussion with @sebastiendeleze, a new issue has been created for this, as it requires some dev effort: Custom metadata fields are missing in the deposit form #534]
  • The facets for custom metadata fields are not visible in the public interface, only in the admin interface.
  • The labels of custom metadata fields should be translatable.

@sebdeleze
Copy link
Contributor Author

  • The facets for custom metadata fields are not visible in the public interface, only in the admin interface.

I think this work as expected. The custom facets are displayed only in the dedicated view, not in the global view.

https://sonardev.test.rero.ch/global/search/documents?q=&page=1&size=10 --> No custom facets
https://sonardev.test.rero.ch/rero/search/documents?q=&page=1&size=10 --> Custom facets

@mmo
Copy link
Collaborator

mmo commented Apr 23, 2021

@sebastiendeleze:

I think this work as expected. The custom facets are displayed only in the dedicated view, not in the global view.

Correct!

@pronguen
Copy link
Contributor

@sebastiendeleze Possible enhancements:

  • Each local field should be an array (repetitive). This will enable more flexibility.
  • The local fields should be indexed for the search. This is not the case.

sebdeleze pushed a commit that referenced this issue May 25, 2021
documents: custom fields for documents
525f586 
* Adds the support of custom fields for dedicated organisations documents.
* Adds the filters and aggregations for the custom fields.
* Creates a custom class for managing JSON schemas, with a factory to instantiate the right class.
* Configures JSON schema and Elasticsearch mapping for the three custom fields.
* Adjusts facets for custom fields depending on the context (dedicated view or not).
* Displays the custom fields in documents detail view.
* Adds properties in organisation (JSON schema and mapping) to configure the behavior of the custom fields.
* Refactors the view serving the JSON schema, to use the new class and factory.
* Closes #512.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documents: custom fields for documents
3 participants
@mmo @sebdeleze @pronguen