Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

documents: data model refactor #116

Merged
merged 1 commit into from
Jan 16, 2020
Merged

documents: data model refactor #116

merged 1 commit into from
Jan 16, 2020

Conversation

sebdeleze
Copy link
Contributor

  • Changes documents data model to match RERO ILS structure.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze requested a review from jma January 8, 2020 11:23
@sebdeleze sebdeleze self-assigned this Jan 8, 2020
item.label = name


@utils.command()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be in a separate invenio module to avoid copy paste between projects.

"""Error printing to sdterr."""
msg = ''
for arg in args:
msg += str(arg) + '\t'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use a join

sys.stderr.flush()


def make_year(date):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a good name? Is the comment is correct?

* Changes documents data model to match RERO ILS structure.
* Cleans rules in MANIFEST.in.
* Closes #96.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 6cda64a into rero:dev Jan 16, 2020
@sebdeleze sebdeleze deleted the sed-document-data-model branch January 16, 2020 19:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants