Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

security: replace pipenv check by safety. #191

Merged
merged 1 commit into from
Apr 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ before_install:
- "nvm install 8; nvm use 8"
- "travis_retry pip install --upgrade pip setuptools py pipenv"
- "travis_retry pip install twine wheel coveralls"
# patch default version of travis which is marked as unsafe by pipenv check
- "travis_retry pip install --upgrade numpy"

install:
- "./scripts/bootstrap"
Expand Down
4 changes: 3 additions & 1 deletion Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ werkzeug = "==0.16.0"
flask-login = "<0.5"
invenio-oaiharvester = {editable = true,ref = "v1.0.0a4",git = "https://github.com/inveniosoftware/invenio-oaiharvester.git"}
# Forced version for security reason
bleach = ">=3.1.3"
bleach = ">=3.1.4"
# TODO: remove this constraint when it's solved by invenio. It causes errors on entry points initialization.
sqlalchemy = "==1.3.15"
# TODO: Remove this when pipenv check will be available again
safety = ">=1.8"

[dev-packages]
Flask-Debugtoolbar = ">=0.10.1"
Expand Down
106 changes: 105 additions & 1 deletion Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion run-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
# Ignoring false positive 36759 (reporting invenio-admin v1.0.1). This can be
# removed when https://github.com/pyupio/safety-db/pull/2274 is merged and
# released.
pipenv check --ignore 36759 --ignore 36810 --ignore 36382 && \

# TODO: Use pipenv check when it will be available again
pipenv run safety check && \
pipenv run pydocstyle sonar tests docs && \
pipenv run isort -rc -c -df && \
pipenv run check-manifest --ignore ".travis-*,docs/_build*" && \
Expand Down