search: USI data searchable #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebdeleze
commented
Jun 4, 2019
sonar/modules/documents/api.py
Outdated
| @@ -40,13 +50,13 @@ class DocumentRecord(SonarRecord): | |||
| @classmethod | |||
| def create(cls, data, id_=None, **kwargs): | |||
There was a problem hiding this comment.
remove this method
sebdeleze
commented
Jun 4, 2019
| "type": "string" | ||
| }, | ||
| "organization": { | ||
| "description": "Organization the author belongs to.", | ||
| "key": { |
sebdeleze
commented
Jun 4, 2019
| @@ -31,6 +31,9 @@ | |||
| <div class="row"> | |||
| <div class="col-12 col-sm-11"> | |||
| <input class="form-control form-control-lg mr-2" type="search" placeholder="{{_('Search publications, authors, projects, ...')}}" aria-label="Search" name="q"> | |||
| {% if g.ir|default('sonar') != 'sonar' %} | |||
There was a problem hiding this comment.
Explore invenio search UI --> search_hidden_params
sebdeleze
commented
Jun 4, 2019
sonar/modules/documents/cli.py
Outdated
| """ | ||
| url = current_app.config.get('SONAR_DOCUMENTS_RERO_DOC_URL') | ||
|
|
||
| click.secho('Importing {} pages of records for "{}" from {}'.format( |
There was a problem hiding this comment.
use named arguments for formats
sebdeleze
commented
Jun 4, 2019
sonar/modules/documents/cli.py
Outdated
| (current_page*10-9), (current_page*10)), nl=False) | ||
|
|
||
| # Read Marc21 data for current page | ||
| response = requests.get(url + '?of=xm&jrec={}&c=NAVSITE.{}'.format( |
There was a problem hiding this comment.
Add URL placeholder to format
sebdeleze
commented
Jun 4, 2019
Pipfile
Outdated
| @@ -30,6 +30,7 @@ pytest-mock = ">=1.6.0" | |||
| pytest-pep8 = ">=1.0.6" | |||
| pytest-random-order = ">=0.5.4" | |||
| pytest-runner = ">=3.0.0,<5" | |||
| pylint = "*" | |||
There was a problem hiding this comment.
remove pylint dependency
sebdeleze
commented
Jun 4, 2019
data/institutions.json
Outdated
| [ | ||
| { | ||
| "name": "Università della Svizzera italiana", | ||
| "key": "usi" |
There was a problem hiding this comment.
use pid instead of key
sebdeleze
commented
Jun 4, 2019
sonar/modules/ext.py
Outdated
| @@ -24,12 +24,10 @@ def __init__(self, app=None): | |||
| def init_app(self, app): | |||
| """Flask application initialization.""" | |||
| self.init_config(app) | |||
| app.extensions['sonar'] = self | |||
| app.extensions['sonar_modules'] = self | |||
There was a problem hiding this comment.
change to sonar_app
sebdeleze
commented
Jun 4, 2019
sonar/modules/ext.py
Outdated
| for k in dir(config): | ||
| if k.startswith('SONAR_'): | ||
| if k.startswith('SONAR_MODULES_'): |
There was a problem hiding this comment.
change to SONAR_APP_
sebdeleze
commented
Jun 4, 2019
sonar/modules/institutions/ext.py
Outdated
| @@ -22,15 +22,15 @@ def __init__(self, app=None): | |||
| def init_app(self, app): | |||
| """Flask application initialization.""" | |||
| self.init_config(app) | |||
| app.extensions['sonar-authors'] = self | |||
| app.extensions['sonar_institutions'] = self | |||
|
|
|||
| def init_config(self, app): | |||
| """Initialize configuration. | |||
|
|
|||
| Override configuration variables with the values in this package. | |||
| """ | |||
| # for k in dir(config): | |||
There was a problem hiding this comment.
Remove unused configuration
sebdeleze
commented
Jun 4, 2019
sonar/modules/institutions/api.py
Outdated
| schema = 'institution' | ||
|
|
||
| @classmethod | ||
| def get_item_by_key(cls, key): |
There was a problem hiding this comment.
this method will be removed as key will not exist anymore
|
@jma I've done the changes we discussed. You can check |
jma
reviewed
Jun 18, 2019
| "default": "https://sonar.ch/schemas/institutions/institution-v1.0.0.json" | ||
| }, | ||
| "pid": { | ||
| "description": "Institution identifier.", |
There was a problem hiding this comment.
please use title instead of description same above
There was a problem hiding this comment.
I corrected the titles and descriptions
NEW Import fixtures from RERO doc. NEW Filter search by contextual IR (USI). BETTER Increase code coverage. Signed-off-by: Sébastien Délèze <sebastien.deleze@rero.ch>
jma
approved these changes
Jun 19, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW Import fixtures from RERO doc.
NEW Filter search by contextual IR (USI).
Signed-off-by: Sébastien Délèze sebastien.deleze@rero.ch