documents: order files #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that files are ordered correctly, for having the main file at first position. The sort is based on `order` property from files. * Adds a method to order and filter files in DocumentRecord. * Removes useless `files_by_type` filter. * Sorts files before dumping them in REST API. Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
|
I do not understand why the order property should be added as files is already an array. Why not take care for sorting during insertion and deletion? |
|
As discussed, it's the only way to re-order files after adding a new file to the list, for example. We don't have the ability to re-order files without keeping the order into a property. |
jma
approved these changes
Oct 12, 2020
pronguen
approved these changes
Oct 19, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that files are ordered correctly, for having the main file at first position. The sort is based on
orderproperty from files.files_by_typefilter.Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch