Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

deposit: improve editor #421

Merged
merged 1 commit into from
Jan 13, 2021
Merged

deposit: improve editor #421

merged 1 commit into from
Jan 13, 2021

Conversation

sebdeleze
Copy link
Contributor

  • Adds publicationPlace and publisher properties.
  • Makes date mandatory and changes description, pattern, placeholder and validation message.
  • Moves language property before otherLanguageTitle.
  • Displays a three rows textarea for title and abstracts.
  • Fixes the display of all placeholders.
  • Extracts translations messages from *Message in JSON schemas.
  • Adds some preferred choices in document type enumeration.
  • Adds provision activity statements for place and agent when a document is create from a deposit.
  • Displays title with carriage returns in documents detail views.
  • Closes Provision activity in deposit editor must be improved. #310.
  • Closes Adjustments in the deposit form #387.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review December 4, 2020 16:48
@sebdeleze sebdeleze requested a review from zannkukai December 4, 2020 16:48
@@ -46,7 +46,7 @@ <h5 class="my-4">{{ _('document_type_' + record.documentType) }}</h5>
{% endif %}
</div>
<div class="col">
<h1 class="text-primary">{{ title }}</h1>
<h1 class="text-primary">{{ title | nl2br | safe }}</h1>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think safe is not required if you use nb2br because the this one does already the safe operation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's the case in angular, but not in jinja with this custom template.

@pronguen pronguen self-requested a review December 23, 2020 08:04
@pronguen
Copy link
Contributor

pronguen commented Dec 23, 2020

  • The date is not displayed for some document type on document detailed view (public + pro interface). It should be displayed after the publisher, i.e. "Paris : Actes Sud, 2001". See next comment, in order to always display only the statement.
  • In RERO ILS, the date is also saved in a provisionActivity.statement.label (last position). This enable to have a date free formatted in the statement, for the display (i.e. MMDCXI or [Ca. 1511]). The startdate is used for facets and sorting options. It should work like this in SONAR, either for all documents, or at least for document having the place and publishers.
    image
  • For documents without any dissertation or parfOf fields, the brief view is very brief (public + pro interface). We should display the trilogy "Paris : Actes Sud, 2001" when it exists. I don't remember the exact rules for the fields to display on this view.
    image

* Adds `publicationPlace` and `publisher` properties.
* Makes date mandatory and changes description, pattern, placeholder and validation message.
* Moves `language` property before `otherLanguageTitle`.
* Displays a three rows textarea for title and abstracts.
* Fixes the display of all placeholders.
* Extracts translations messages from `*Message` in JSON schemas.
* Adds some preferred choices in document type enumeration.
* Adds provision activity statements for place and agent when a document is create from a deposit.
* Displays title with carriage returns in documents detail views.
* Closes #310.
* Closes #387.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 1b67c89 into rero:dev Jan 13, 2021
@sebdeleze sebdeleze deleted the sed-deposit-improvments branch January 13, 2021 07:15
@sebdeleze sebdeleze added f: deposits Related to deposits enhancement Enhancement of an existing feature labels Jan 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Enhancement of an existing feature f: deposits Related to deposits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustments in the deposit form Provision activity in deposit editor must be improved.
3 participants