-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
deposit: improve editor #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
approved these changes
Dec 7, 2020
@@ -46,7 +46,7 @@ <h5 class="my-4">{{ _('document_type_' + record.documentType) }}</h5> | |||
{% endif %} | |||
</div> | |||
<div class="col"> | |||
<h1 class="text-primary">{{ title }}</h1> | |||
<h1 class="text-primary">{{ title | nl2br | safe }}</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think safe
is not required if you use nb2br
because the this one does already the safe operation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It's the case in angular, but not in jinja with this custom template.
* Adds `publicationPlace` and `publisher` properties. * Makes date mandatory and changes description, pattern, placeholder and validation message. * Moves `language` property before `otherLanguageTitle`. * Displays a three rows textarea for title and abstracts. * Fixes the display of all placeholders. * Extracts translations messages from `*Message` in JSON schemas. * Adds some preferred choices in document type enumeration. * Adds provision activity statements for place and agent when a document is create from a deposit. * Displays title with carriage returns in documents detail views. * Closes #310. * Closes #387. Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
pronguen
approved these changes
Jan 12, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publicationPlace
andpublisher
properties.language
property beforeotherLanguageTitle
.*Message
in JSON schemas.Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch