Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

authentication: fix Switch edu-ID authentication #444

Merged
merged 1 commit into from
Feb 2, 2021
Merged

authentication: fix Switch edu-ID authentication #444

merged 1 commit into from
Feb 2, 2021

Conversation

sebdeleze
Copy link
Contributor

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review January 25, 2021 16:09
@sebdeleze sebdeleze added bug Breaks something but is not blocking f: user management Related to users labels Jan 27, 2021
@pronguen
Copy link
Contributor

The correction works!

Other problem encountered (not prioritary): it is possible to create 2 users with the same e-mail, because of maj/min differences, see image.
image
When I then login,

  • I receive an internal error server when I use Switch edu-id
  • I receive a message "Cet utilisateur n'a pas de mot de passe" when I use the standard login form, whatever the e-mail is (with or without maj)

authentication: fix Switch edu-ID authentication
657713a 
* Fixes an issue when the accounts from Switch and Invenio are linked and the email address are not corresponding because of case sensivity.
* Makes the check for the existence of a user email case insensitive.
* Closes #397.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze
Copy link
Contributor Author

Other problem encountered (not prioritary): it is possible to create 2 users with the same e-mail, because of maj/min differences, see image.
image
When I then login,

  • I receive an internal error server when I use Switch edu-id
  • I receive a message "Cet utilisateur n'a pas de mot de passe" when I use the standard login form, whatever the e-mail is (with or without maj)

I tried a fix, be not sure it's OK. If it's not the case, I suggest to create an issue with more details.

@pronguen pronguen self-requested a review February 1, 2021 08:40
@sebdeleze sebdeleze merged commit 1759c52 into rero:staging Feb 2, 2021
@sebdeleze sebdeleze deleted the sed-switch-issue branch February 2, 2021 06:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pronguen pronguen pronguen approved these changes

Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: user management Related to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email check is case sensitive when try to login with a switch edu-ID account
2 participants
@sebdeleze @pronguen