Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

design: improve responsive display #477

Merged
merged 1 commit into from
Feb 12, 2021
Merged

design: improve responsive display #477

merged 1 commit into from
Feb 12, 2021

Conversation

sebdeleze
Copy link
Contributor

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review February 9, 2021 08:58
@sebdeleze sebdeleze added design enhancement Enhancement of an existing feature labels Feb 9, 2021
@pronguen pronguen self-requested a review February 10, 2021 17:42
Copy link
Contributor

@pronguen pronguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebdeleze
Copy link
Contributor Author

This page will be created by @mmo. It already exists in the preview website https://60230e5cadadb33bfce52a8c--sonardotch.netlify.app/contact/.

  • Not sure that "#" should be more visible than "Log in", the latter is more frequently used. I am open to other opinion, but this does not cover any of the proposals in # / # distinction #365

I think the call to action for Register should be kept highlighted. People who already have a login, know where the link is. Those who don't have one, should quickly find the button Register. This is the case on most applications.

* Improves the display in small screens.
* Changes the links and display for # and # actions.
* Changes occurrences `#` for `Log in`.
* Updates the frontpage.
* Add spaces between jinja variable print.
* Closes #365.
* Closes #474.
* Closes #476.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 11541bb into rero:staging Feb 12, 2021
@sebdeleze sebdeleze deleted the sed-update-frontpage branch February 12, 2021 11:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Enhancement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update frontpage Improve responsive display # / # distinction
4 participants