project: optimize loading speed and SEO #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
approved these changes
Feb 10, 2021
Garfield-fr
approved these changes
Feb 11, 2021
* Optimizes loading speed and SEO after running a Lighthouse test. * Removes webpack entry for `app` and moves `app.js` file in static files. * Removes useless dependencies `popper.js` and `jquery`. * Triggers dropdowns in vanilla javascript instead of using jQuery. * Removes unsused local Roboto font. * Loads Roboto font and Font-awesome externally. * Adds a configuration for integrating analytics tracking code. * Removes useless `/` in html closing tags. * Closes #111. * Closes #112. Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appand movesapp.jsfile in static files.popper.jsandjquery.Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch