Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

templates: add language value filter #565

Merged
merged 1 commit into from
May 25, 2021
Merged

templates: add language value filter #565

merged 1 commit into from
May 25, 2021

Conversation

sebdeleze
Copy link
Contributor

  • Adds a filter to get the value corresponding to a language in a list property.
  • Moves get_bibliographic_code_from_language into utils functions.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review May 19, 2021 14:15
@sebdeleze sebdeleze requested review from jma and zannkukai May 19, 2021 14:15
Comment on lines 257 to 258
if not locale:
locale = get_current_language()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COSMETIC : locale = locale or get_current_language()?

* Adds a filter to get the value corresponding to a language in a list property.
* Moves `get_bibliographic_code_from_language` into utils functions.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 75488c8 into rero:staging May 25, 2021
@sebdeleze sebdeleze deleted the sed-language-value-filter branch May 25, 2021 07:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants