Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

documents: fill out custom fields for ROAR during RERO DOC import #656

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

mmo
Copy link
Collaborator

@mmo mmo commented Oct 4, 2021

  • adds specific transformation to RERO DOC import for ROAR,
    in order to fill out custom fields Filière (customField1)
    and Titre obtenu (customField2)
  • fixes bug in customField facet label definition
  • fixes typo in FREDI description

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@mmo mmo force-pushed the mmo-bejune-import-custom-fields branch from 23fb331 to 96420b4 Compare October 5, 2021 10:25
* Adds specific transformation to RERO DOC import for ROAR,
  in order to fill out custom fields `Filière` (`customField1`)
  and `Titre obtenu` (`customField2`).
* Fixes bug in customField facet label definition.
* Fixes typo in FREDI description.

Co-Authored-by: Miguel Moreira <miguel.moreira@rero.ch>
@mmo mmo force-pushed the mmo-bejune-import-custom-fields branch from 96420b4 to 99e3439 Compare October 5, 2021 14:02
@jma jma merged commit 9978630 into rero:staging Nov 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants