Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

deposit: fix moderator validation #697

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Nov 8, 2021

  • Fixes the validation of a deposit by a moderator when the license is
    not defined.
  • Makes the license required in the deposit form.
  • Fixes missing fields for book chapter.

Co-Authored-by: Johnny Mariéthoz johnny.mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

* Fixes the validation of a deposit by a moderator when the license is
  not defined.
* Makes the license required in the deposit form.
* Fixes missing fields for book chapter.

Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
@jma jma requested review from mmo, vgranata and Garfield-fr November 8, 2021 15:59
@jma jma merged commit 1dc7acb into rero:staging Nov 10, 2021
@jma jma deleted the maj-fix-moderator-validation branch February 7, 2022 15:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants