Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests: fix hardcoded embargo date #750

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

jma
Copy link
Contributor

@jma jma commented Jan 18, 2022

  • Creates a new embargo date fixture in one year in the future.
  • Removes all hard coded embargo date in the tests.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

* Creates a new embargo date fixture in one year in the future.
* Removes all hard coded embargo date in the tests.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma requested review from mmo, BadrAly and Garfield-fr January 18, 2022 07:34
@jma jma merged commit 2422b85 into rero:staging Jan 18, 2022
@jma jma deleted the maj-fix-tests-embargo-date branch February 7, 2022 15:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants