Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

module: invenio-record-resources #786

Merged
merged 1 commit into from
Aug 10, 2022
Merged

module: invenio-record-resources #786

merged 1 commit into from
Aug 10, 2022

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 17, 2022

  • Updates invenio-record-resources from version v.0.12.5 to v0.16.14.
    Versions greater then 17 are not working for invenio 3.4.
  • Adds --port parameter to server script.

Co-Authored-by: Peter Weber peter.weber@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@rerowep rerowep requested review from Garfield-fr, mmo and jma February 17, 2022 14:41
@rerowep rerowep self-assigned this Feb 17, 2022
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch 2 times, most recently from 2f9568a to 97a2f2f Compare February 17, 2022 15:05
@rerowep rerowep requested a review from zannkukai February 17, 2022 15:23
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch 6 times, most recently from 0491f77 to 9dc9135 Compare February 22, 2022 07:25
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch 9 times, most recently from 5f8a135 to d1c6c7d Compare February 24, 2022 08:03
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch 2 times, most recently from 4c1932a to 2605899 Compare March 7, 2022 14:59
@PascalRepond PascalRepond force-pushed the staging branch 2 times, most recently from 9cf96c3 to 7b8082a Compare March 10, 2022 10:56
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch from 2605899 to 654192a Compare March 10, 2022 11:09
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch from 654192a to 6164215 Compare March 10, 2022 12:33
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch 3 times, most recently from 121e374 to 61d1fd0 Compare March 10, 2022 18:11
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch 7 times, most recently from e45c1f0 to 050fc91 Compare March 19, 2022 23:11
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch 5 times, most recently from 557e7a8 to 5295171 Compare March 29, 2022 19:54
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch 3 times, most recently from f6ae7df to d147be4 Compare April 12, 2022 08:02
jma
jma approved these changes Apr 26, 2022
View reviewed changes
pyproject.toml
invenio-records-resources = "==0.12.5"
invenio-records = "<=1.7.0"
invenio-stats = "^1.0.0a18"
invenio-records-resources = "*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this need a version greater than xxx.

@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch 2 times, most recently from 6b1f422 to 457d635 Compare June 2, 2022 20:16
@pronguen
Copy link
Contributor

pronguen commented Jun 7, 2022 •
edited
Loading

  • NPR: The menu "Research projects" (/manage/records/projects) in the professional interface gives a 404 not found
  • NPR: In the document editor, the suggestions within the fields projects (Research projects) are not working > impossible to create a link
  • NPR: trying to submit a project, as a submitter of HEP Valais: it spins forever
    image

@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch from 457d635 to be5b1c0 Compare June 8, 2022 14:23
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch from be5b1c0 to 733b72a Compare August 2, 2022 06:57
@rerowep @jma
module: invenio-record-resources
e2cd855 
* Updates `invenio-record-resources` from version v.0.12.5 to v0.16.14.
  Versions greater then 17 are not working for `invenio 3.4`.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@rerowep rerowep force-pushed the wep-update-invenio-record-resources branch from 733b72a to e2cd855 Compare August 9, 2022 14:02
@rerowep rerowep merged commit c18b0ae into rero:staging Aug 10, 2022
@rerowep rerowep deleted the wep-update-invenio-record-resources branch January 31, 2024 07:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jma jma jma approved these changes

@zannkukai zannkukai zannkukai approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@mmo mmo Awaiting requested review from mmo

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rerowep @pronguen @jma @zannkukai