Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

oai: fix error on document type processing #793

Merged
merged 1 commit into from
Mar 9, 2022
Merged

oai: fix error on document type processing #793

merged 1 commit into from
Mar 9, 2022

Conversation

Garfield-fr
Copy link
Contributor

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr self-assigned this Feb 24, 2022
@Garfield-fr Garfield-fr force-pushed the zub-oai-document-type-fix branch from b89e93c to e1554d9 Compare February 24, 2022 14:15
@pronguen
Copy link
Contributor

pronguen commented Mar 2, 2022 •
edited
Loading

  • The type is not exported for non COAR values. It should be exported, for instance like this:
    • <dc:type>advanced_studies_thesis</dc:type>
    • COAR values keep their full URL in Dublin Core

@Garfield-fr Garfield-fr force-pushed the zub-oai-document-type-fix branch 2 times, most recently from 4372223 to faf5ede Compare March 2, 2022 13:36
@Garfield-fr Garfield-fr force-pushed the zub-oai-document-type-fix branch 2 times, most recently from a64ca79 to a352f51 Compare March 3, 2022 10:45
@Garfield-fr @jma
oai: fix error on document type processing
47edc03 
* Closes rero#789.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-oai-document-type-fix branch from a352f51 to 47edc03 Compare March 7, 2022 11:29
@Garfield-fr Garfield-fr added this to the v1.6.0 milestone Mar 7, 2022
@Garfield-fr Garfield-fr merged commit 8f3e748 into rero:staging Mar 9, 2022
@Garfield-fr Garfield-fr deleted the zub-oai-document-type-fix branch March 14, 2022 06:37
@pronguen pronguen mentioned this pull request Mar 17, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mmo mmo mmo approved these changes

@pronguen pronguen pronguen approved these changes

@rerowep rerowep rerowep approved these changes

@jma jma Awaiting requested review from jma

Assignees

@Garfield-fr Garfield-fr

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

OAI-DC export bug if the document type is not a COAR type
4 participants
@Garfield-fr @pronguen @mmo @rerowep