Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dependencies: upgrade invenio packages #966

Merged
merged 1 commit into from
Jan 22, 2024
Merged

dependencies: upgrade invenio packages #966

merged 1 commit into from
Jan 22, 2024

Conversation

jma
Copy link
Contributor

@jma jma commented Dec 20, 2023

No description provided.

@jma jma force-pushed the maj-flask2 branch 6 times, most recently from d817497 to 25bad47 Compare December 21, 2023 15:12
@jma jma marked this pull request as ready for review December 21, 2023 15:18
@jma jma changed the title flask2: in progress dependencies: upgrade invenio packages Dec 21, 2023
@jma jma force-pushed the maj-flask2 branch 2 times, most recently from d5ec53c to bf8742c Compare January 8, 2024 10:30
@api_blueprint.route('/translations/<lang>.json')
def get_translations(lang):
"""Exposes translations in JSON format.

:param lang: language ISO 639-1 Code (two chars).
:param ln: language ISO 639-1 Code (two chars).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter is named lang.

@jma jma force-pushed the maj-flask2 branch 4 times, most recently from 9441e75 to da54e8a Compare January 9, 2024 09:32
@jma jma force-pushed the maj-flask2 branch 3 times, most recently from edf1332 to 3a48be1 Compare January 15, 2024 10:52
@mmo
Copy link
Collaborator

mmo commented Jan 16, 2024

Tests

  • 'invenio_accounts.models.User object' has no attribute 'profile'
    •  After setting the password for a new user with the link in the mail: an error 500 is returned instead of connecting the user. The password is nevertheless stored correctly. (SONAR-DEV-PY) See Event ID 789a9469b0f64acd8b740b35559266b1
    • Similar error when trying to send a reset password email for existing user (SONAR-DEV-Q2), error 500 and the reset email is not sent
  • There is an error in sentry when adding a research project to a document metadata, but it still works as intended (SONAR-DEV-PZ)
  • Impossible to add a logo to an organisation or a collection (the "Add" button is missing). The bug exists in prod as well.
    • REP: Not blocking and already exists in prod: unless it is a very easy fix, we should open an issue

  • When deleting a user, the screen gets frozen and the user is not deleted. See event ID 88915b79e35f46b2ba4ec6ee3d84d2bc

@mmo mmo closed this Jan 16, 2024
@PascalRepond PascalRepond reopened this Jan 16, 2024
@jma jma force-pushed the maj-flask2 branch 3 times, most recently from 7aadcd9 to 1d6fddd Compare January 18, 2024 12:28
@jma jma force-pushed the maj-flask2 branch 2 times, most recently from 64fe69c to c111821 Compare January 18, 2024 14:04
* Uses Flask2.
* Uses node 18 for docker production images.
* Uses flask-babel instead of flask-babelex.
* Uses specific indexer class for document bulk indexing.
* Moves to grobid 0.8.0.
* Uses invenio-queues>1.0.0 to close redis channel for celery.
* Fixes reset password messages.
* Adds permissions for organisation and collection resources.
* Keeps the invenio users with the user role only when a professional is removed.
* Considers only ui document detailed view for the record-view stats.

Co-authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma merged commit eea3f9f into rero:staging Jan 22, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants