validate instanceId format

rerobots · Feb 20, 2025 · 5b024f9 · 5b024f9
1 parent 1d98219
commit 5b024f9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/util.ts b/src/util.ts
@@ -1,4 +1,10 @@
+const uuidRegex =
+    /^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}$/;
+
 export function instanceKeepAlive(instanceId: string, token: string) {
+    if (!uuidRegex.test(instanceId)) {
+        throw new Error('instanceId not of valid form');
+    }
     return fetch(`https://api.rerobots.net/instance/${instanceId}/ka`, {
         method: 'POST',
         headers: {

diff --git a/tests/instanceKeepAlive.test.ts b/tests/instanceKeepAlive.test.ts
@@ -5,3 +5,9 @@ test('unauthenticated calls fail', () => {
         instanceKeepAlive('1926b858-0d00-4b84-b7ca-5c56be880525', ''),
     ).rejects.toThrow();
 });
+
+test('call with broken ID format fails', () => {
+    expect(() =>
+        instanceKeepAlive('926b858-0d00-4b84-b7ca-5c56be880525', ''),
+    ).toThrow(/instanceId/);
+});