-
Notifications
You must be signed in to change notification settings - Fork 447
Make Position2D components editable in selection panel #8357
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
singleline_edit_position2d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those brackets are a bit of a stylistic break. Which I don't actually mind, but this should be integrated & aligned with https://github.com/rerun-io/rerun/blob/main/crates/viewer/re_component_ui/src/datatype_uis/vec.rs
I.e. that file should be extended with vec2 and then used instead
oh interesting, so actually it preserves the style of non-editable better than what's there in vec.rs |
oops sorry mouse slipped and clicked the wrong button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Andreas Reich <andreas@rerun.io>
Related
What
This adds a simple single line edit for position 2D. There is no
speed_fn
because I think in most applications UI coordinates are probably good unit (for example in graphs).Screen.Recording.2024-12-09.at.10.14.30.mov