Fix opening partitions from redap origins with port 443 or 80 #9511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
lucasmerlin
added
🪳 bug
emilk
approved these changes
Apr 7, 2025
| // If we parse a Url from e.g. `https://redap.rerun.io:443`, `port` in the Url struct will | ||
| // be `None`. So we need to use `port_or_known_default` to get the port back. | ||
| // See also: https://github.com/servo/rust-url/issues/957 | ||
| if http_url.port_or_known_default().is_none() { |
There was a problem hiding this comment.
Well this is very annoying. This means the default port logic doesn't work.
We talked this through in a huddle, and decided we'll leave it as a TODO until servo/rust-url#957 is fixed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes opeing recordings from redap.rerun.io