Skip to content

Update tailwind #79

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Update tailwind #79

merged 2 commits into from
Jan 27, 2025

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 27, 2025

  • Update Vite to v6
  • Update Tailwind to v4 (removed autoprefix and postcss in the process)
  • Change the counter example to match the Vite + React sample a bit better.

image

@nojaf
Copy link
Contributor Author

nojaf commented Jan 27, 2025

For reference:

image

@fhammerschmidt
Copy link
Member

As usual: Does fast refresh still work?

@nojaf
Copy link
Contributor Author

nojaf commented Jan 27, 2025

As usual: Does fast refresh still work?

Yup!

@fhammerschmidt
Copy link
Member

fhammerschmidt commented Jan 27, 2025

Good.

Ad the template name: Technically it would be a Vite + React + ReScript template.

And I don't just want to be pedantic here, but what if we have someday a React-less template that just uses the new webapi?

@nojaf
Copy link
Contributor Author

nojaf commented Jan 27, 2025

Ad the template name: Technically it would be a Vite + React + ReScript template.

That is true, although I would cross that bridge when we create a second template.
(If there even is a demand for that)

I can update it though, if you feel strongly about it.

@fhammerschmidt fhammerschmidt requested a review from cknitt January 27, 2025 14:52
@fhammerschmidt
Copy link
Member

Nah.

But I also requested a review from @cknitt
(btw. this repo still uses buildjet)

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot!

@cknitt cknitt merged commit 6b397d9 into rescript-lang:master Jan 27, 2025
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants