Skip to content

Add link from legacy Js modules to their current Core equivalents. #879

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaspard
Copy link

@gaspard gaspard commented Jun 8, 2024

Having a clear warning that Core supersedes Js helps remove some confusion for newcomers. It also avoids people trying to understand code samples that use legacy features such as |>.

Having a clear warning that Core supersedes Js helps remove
some confusion for newcomers. It also avoids people trying to
understand code samples that use legacy features such as |>.
Copy link

vercel bot commented Jun 8, 2024

@gaspard is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

@aspeddro
Copy link
Collaborator

aspeddro commented Jun 9, 2024

@gaspard, thanks for the contribution!!

json files are generated by the document generator @recript/tools. I like the idea of ​​adding a deprecation message.

It's better to do this in next.js side, here

@fhammerschmidt
Copy link
Member

@aspeddro would we not need to add the deprecation messages to the compiler sources themselves?

@aspeddro
Copy link
Collaborator

If when Core was added in the compiler and keeping Js for some time it makes sense to add @deprecated in the Js module. But since Core is now an independent package it doesn't make sense to add any @deprecated in Js.

In short, it depends on how the transition from Js to Core will be in the compiler

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants