Skip to content

Update @rescript/react dependency in workspace and use it for more tests #7525

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 26, 2025

Add latest @rescript/react to packages/react and the yarn workspace and use it in tests, analysis tests, tools_tests, gentype_tests.

  • Reduces the number of copies of @rescript/react in the repo
  • Allows us to more easily evolve @rescript/react, e.g., move DOM props from runtime into @rescript/react in the future

This is not meant to replace the separate repo https://github.com/rescript-lang/rescript-react though, we'd still do @rescript/react releases from there to be able to release versions independently from compiler versions.

There was already a copy in tests/dependencies, too, but I think the location under packages is more prominent.

@cknitt
Copy link
Member Author

cknitt commented May 26, 2025

There was already a copy in tests/dependencies, too, but I think the location under packages is more prominent.

Ok, disadvantage of that is that the packages under packages are enforced to have the same version number as the compiler, maybe I should leave it in tests/dependencies after all.

@cknitt cknitt changed the title Add latest @rescript/react to packages Update @rescript/react dependency in workspace and use it for more tests May 27, 2025
Copy link

pkg-pr-new bot commented May 27, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7525

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7525

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7525

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7525

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7525

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7525

commit: 9089886

@cknitt
Copy link
Member Author

cknitt commented May 27, 2025

@zth Do you have any idea what may be causing the changes in the analysis test output?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant