Retain journal after completion #3250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
issues/892
branch
from
f968c6b to
e3a5b96
Compare
…his is by default disabled, and enabled when JournalRetentionPolicy::Retain
Add business logic to remove journal when purging invocation.
This also includes few sensible changes to the internal API InvocationTargetMetadata, to map its values more easily to what the ServiceInvocation supports.
slinkydeveloper
force-pushed
the
issues/892
branch
from
e3a5b96 to
1209e3c
Compare
slinkydeveloper
changed the title
slinkydeveloper
commented
May 22, 2025
| } | ||
| } | ||
|
|
||
| pub fn compute_retention(&self, has_idempotency_key: bool) -> InvocationRetention { |
There was a problem hiding this comment.
For the review, this is super important.
Closed
|
For context, this is the deployment manifest PR: #3295 |
There was a problem hiding this comment.
I accidentally started with the last PR in line and therefore added all my comments to #3296. Some of which might actually apply to this PR. Sorry for this.
|
Merged with #3296 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #892
This PR makes sure we store in the completed invocation status the journal length, adds purge journal command, adds support in the cleaner to purge the journal, adds journal retention to invocation request (to be propagated from the schema registry, see followup prs).
TODO for myself to finish this:
Evaluate whether we need disabling workflow retention default for 1.4 (because of backward compatibility).This needs version gapIntroduce something likeWe don't do it, I rather do in a followup a hidden flag to enable journal retention for everything by default.restate-server --dev, to set journal retention on by default for all invocations during development.