Use Minio's optimized SHA-256 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buschjost
force-pushed
the
optimized-sha256-lib
branch
from
ece3d84 to
f61292b
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
This switches the SHA256 verification to Minios optimized library. This results in improved throughput for many processors.
This is the same library that is also used in Restic (see restic/restic#2709 )
Was the change discussed in an issue or in the forum before?
Shortly as remark in #130 where the verification of uploaded files was introduced.
Checklist
I have added tests for all changes in this PRI have added documentation for the changes (in the manual)There's a new file in(https://github.com/restic/rest-server/blob/master/changelog/TEMPLATE))changelog/unreleased/that describes the changes for our users (template [here]gofmton the code in all commitsI did not include a Changelog entry as this just improves an unreleased feature. But I can add one.