Add configurable htpasswd location #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming that updating the readme suffices for updating documentation, I have marked that complete as well. If there is additional documentation needed, I would be glad to add that. |
rawtaz
requested changes
Mar 26, 2022
mux.go
Outdated
| } | ||
| log.Printf("Loaded htpasswd file: %s", server.HtpasswdPath) |
There was a problem hiding this comment.
Nitpick, but if you don't mind I think we should remove this : in order to be consistent with other output/messages.
cmd/rest-server/main_test.go
Outdated
| @@ -100,6 +100,22 @@ func TestGetHandler(t *testing.T) { | |||
| t.Errorf("NoAuth=true: expected no error, got %v", err) | |||
| } | |||
|
|
|||
| // With NoAuth = true and custom .htpasswd | |||
There was a problem hiding this comment.
Should this be "With NoAuth = false and custom .htpasswd"?
dwmunster
force-pushed
the
f-config-htpasswd
branch
from
2bf5d60 to
bc1545c
Compare
|
Perhaps a new image should be published with that feature? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
Allows users to configure the location of the
.htpasswdfile.Was the change discussed in an issue or in the forum before?
Closes #187
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits