stats: Fix hardlink tracking across multiple filesystems #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
fix-stats-with-hardlinks
branch
from
85a9bab to
32e4d8e
Compare
This will allow reusing it for the stats command without regressing the memory usage due to storing an unnecessary file path.
inodes are only unique within a device. Use the HardlinkIndex from the restorer instead of the custom (broken) hashmap to correctly account for both inode and deviceID.
MichaelEischer
force-pushed
the
fix-stats-with-hardlinks
branch
from
32e4d8e to
731b3a4
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
The
statscommand only counts hardlinked files once. However, the calculation did not include the deviceID and consequently inodeIDs from different devices might be considered to be hardlinked to one another.Was the change previously discussed in an issue or on the forum?
Might fix https://forum.restic.net/t/possible-bug-in-stats/6461/8
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.