Skip to content

Remove note that 404 response code means succes #2281

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jnoordsij
Copy link

@jnoordsij jnoordsij commented Feb 6, 2025

Description

Looking into the documentation on handling responses, I found a note on IsSuccessfulStatusCode mentioning "that 404 response code means succes". However, when checking implementation and tests, I found only that ResponseStatus will be Completed on 404 responses, but IsSuccessfulStatusCode should be false.

See also:

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant