Can't connect to server with http admin turned off #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver006
changed the title
|
Thanks for this @oliver006, I completely forgot that the HTTP admin port might not be set. That being said I think I agree with your point about removing the field since its completely unused. Would you be able to make this change? |
|
Done. |
|
Amazing thanks! Ill get this merged in the next version (v0.7.2) however I am not sure when this is yet due to a couple of other issues. |
|
Ok, sounds good. |
dancannon
added a commit
that referenced
this pull request
May 5, 2015
Can't connect to server with http admin turned off
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the http admin interface is disabled for a server the driver fails to connect. Reason is that the
server_statustable returns"http_admin_port": "<no http admin>" ,but the driver expects the port to be a number. As a result, no connection can be made.This PR changes the data type for HTTPAdminPort to string. Another way to fix this would be to remove the field, it's not used anyway.
This also fixes a bug in the example in the README.