Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show shellcheck version after install #71

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

abitrolly
Copy link
Contributor

No description provided.

Copy link

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abitrolly
Copy link
Contributor Author

@javierjulio I am trying to troubleshoot pkgxdev/setup#259

Do you know why this action doesn't show anything for this PR?

@shogo82148 shogo82148 merged commit 958d9e1 into reviewdog:master Jan 15, 2025
3 checks passed
@review-dog
Copy link
Member

Hi, @abitrolly! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

@shogo82148
Copy link
Contributor

I've released a new version: https://github.com/reviewdog/action-shellcheck/releases/tag/v1.29.0
try it.

@abitrolly abitrolly deleted the patch-1 branch January 15, 2025 12:54
@abitrolly
Copy link
Contributor Author

@shogo82148 thanks. It works https://github.com/pkgxdev/setup/actions/runs/12788860253/job/35651020374?pr=259

However, mistakes in .sh files that exist locally are not being reported in CI.

@shogo82148
Copy link
Contributor

This is the intended behavior.
Reviewdog reports only the issues found in the changes made within the Pull Request.

@abitrolly
Copy link
Contributor Author

Would be nice if the log could explain that it deliberately skipped files that were not touched.

If I touch a file, will this action report all errors?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants