Added SPEC=... to set path to .feature file to run tests from #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexkrechik please review |
Marketionist
force-pushed
the
feature/add-spec-run
branch
2 times, most recently
from
1533b3c to
4b38593
Compare
Marketionist
force-pushed
the
feature/add-spec-run
branch
from
4b38593 to
64c2eb1
Compare
alexkrechik
requested changes
Mar 11, 2018
cucumber.sh
Outdated
| ./node_modules/.bin/wdio test/wdio.conf.js | ||
| #Use SPEC="..." to set path to .feature file to run tests from | ||
| if [ "$SPEC" == "" ]; then | ||
| ./node_modules/.bin/wdio test/wdio.conf.js |
There was a problem hiding this comment.
May be would be better to use something like
const specPart = $SPEC ? ' --spec "$SPEC"' : ''
./node_modules/.bin/wdio test/wdio.conf.js + specPart
This will exclude wdio.conf.js copy-pasting + will give us an ability to add extra path parts.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds SPEC="..." environment variable to set path to .feature file to run tests from